fix: add react-code-editor dev dependency#162
Merged
nicolethoen merged 3 commits intomainfrom Jan 3, 2025
Merged
Conversation
nicolethoen
force-pushed
the
add_code_editor
branch
from
65573c7 to
753d7ba
Compare
fhlavac
approved these changes
Dec 11, 2024
Contributor
Author
|
I have no idea what's happening with the tests. I'll sort that out before we merge and hopefully the build will be fixed 🤞🏻 |
nicolethoen
force-pushed
the
add_code_editor
branch
from
753d7ba to
f6177f6
Compare
|
🎉 This PR is included in version 7.0.0-prerelease.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should (hopefully) fix the build for the outstanding dependencies 🤞🏻
when running
npm installlocally, I think you'll need to addnpm install --legacy-peer-depsuntil the next PF release and we can bump to a version of the docs-framework which will be more compatible and not require that flag. I'll try to keep an eye on that.